[PATCH] D29120: [ImplicitNullCheck] Extend canReorder scope

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy requested changes to this revision.
sanjoy added a comment.
This revision now requires changes to proceed.

Hi Serguei,

The code itself LGTM.

However:

Can you please try to write MIR test cases for this?  That's typically
a more straightforward way to unit test codegen passes.
`implicit-null-check.ll` was added before the MIR infrastructure was
added to LLVM.  You can get started with MIR at
http://llvm.org/docs/MIRLangRef.html, and may use
https://reviews.llvm.org/rL293126 as a template to write your own
test.

Secondly, phabricator tells me that you've changed the permissions on
the .ll files; please make sure you've fixed them before checkin.


https://reviews.llvm.org/D29120