[PATCH] D29109: [APFloat] Fix comments. NFC.

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 16:23:34 PST 2017


timshen added a comment.

s/normalized/normal/ in the commit. I committed before uploading it to Phab. :P



================
Comment at: llvm/lib/Support/APFloat.cpp:70
+  /* The IBM double-double semantics. Such a number consists of a pair of IEEE
+     64-bit doubles (Hi, Lo), where |Hi| > |Lo|, and if normalized,
+     (double)(Hi + Lo) == Hi. The numeric value it's modeling is Hi + Lo.
----------------
jlebar wrote:
> I think "if normal" or "if not denormal" is what you want.  "if normalized" implies that you may be able to take *any* Hi/Lo and "normalize" them so that this criterion is true.  But that's not true for some values (namely, denormals).
> 
> Unless we use "normalized" elsewhere in apfloat, in which case, whatever.  :)
Changed to normal as APFloat uses it in other places too.

FWIW, https://en.wikipedia.org/wiki/Denormal_number aliases these two terms.


Repository:
  rL LLVM

https://reviews.llvm.org/D29109





More information about the llvm-commits mailing list