[PATCH] D29156: [LoopUnroll] Properly update loopinfo for runtime unrolling by 2

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM. I also looked into creating a patch for this issue and I think this patch addresses the issue relatively nicely.



================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:205
+
+    if (NewLoopParent) {
+      NewLoopParent->addChildLoop(NewLoop);
----------------
Unnecessary { and }, not sure if you want to keep them. In your change in LoopUnrollRuntime.cpp you don't use them for single statement blocks.


https://reviews.llvm.org/D29156