[PATCH] D28813: [CodeGenPrepare] Sink and duplicate more 'and' instructions.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 11:18:42 PST 2017


qcolombet added a comment.

Hi,

Given this is CGP, I would like to see `opt -codegenprepare` checks as well.

Cheers,
-Quentin



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:1091
+static bool sinkAndCmp0Expression(Instruction *AndI,
+                                  const TargetLowering &TLI) {
+
----------------
Could you add an assert for !InsertedInsts.count(AndI)


https://reviews.llvm.org/D28813





More information about the llvm-commits mailing list