[PATCH] D27169: [x86] Fix getAddressFromInstr

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 10:50:50 PST 2017


qcolombet added a comment.

Hi,

Do you have a test case to go along this?

Thanks,
-Quentin



================
Comment at: lib/Target/X86/X86InstrBuilder.h:112
   const MachineOperand &Op3 = MI->getOperand(Operand + 3);
-  if (Op3.isGlobal())
+  // FIXME: Handle additional types of memory references below.
+  if (Op3.isGlobal()) {
----------------
Could you describe what is missing?


https://reviews.llvm.org/D27169





More information about the llvm-commits mailing list