[PATCH] D29115: [AMDGPU] Bump up n_type for metadata v2

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 09:45:28 PST 2017


kzhuravl added a comment.

In https://reviews.llvm.org/D29115#655901, @arsenm wrote:

> In https://reviews.llvm.org/D29115#655900, @kzhuravl wrote:
>
> > In https://reviews.llvm.org/D29115#655884, @arsenm wrote:
> >
> > > Needs a test update?
> >
> >
> > No. But we can add a check lines to metadata tests to check for n_type?
>
>
>
>
> In https://reviews.llvm.org/D29115#655900, @kzhuravl wrote:
>
> > In https://reviews.llvm.org/D29115#655884, @arsenm wrote:
> >
> > > Needs a test update?
> >
> >
> > No. But we can add a check lines to metadata tests to check for n_type?
>
>
> Yes, I think it's surprising there wasn't one before


I have added such test in https://reviews.llvm.org/D29131


https://reviews.llvm.org/D29115





More information about the llvm-commits mailing list