[PATCH] D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug.

Martin Böhme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 07:33:51 PST 2017


mboehme added a comment.

In https://reviews.llvm.org/D29124#656235, @rengolin wrote:

> Then say that on the description. What introduced the bug, how did you find out, etc. It helps a lot to know where things came from, not just what they are.


Agree that I should have provided this context. Will do so in the future.

> I'd argue the same thing, but once you posted for review, you *have* to let it linger. This is in the developer policy and it should be followed.

Apologies -- I was under the impression that post-commit review also involved uploading the patch to Phabricator. I understand now that this is not the case?

My intention here was to obtain a post-commit review from rovka but also to make it clear that bkramer had looked at the change. But I obviously didn't follow the usual process here -- sorry for this, I didn't mean to cause any aggravation or confusion.


Repository:
  rL LLVM

https://reviews.llvm.org/D29124





More information about the llvm-commits mailing list