[PATCH] D28985: [Builtin][ARM] Add Thumb1 support for aeabi_c{f,d}cmp.S and dcmp.S

[Renato Golin via llvm-commits]

On 24 January 2017 at 22:10, Zhao, Weiming <weimingz at codeaurora.org> wrote:
> Hi Renato,
>
> How about changing the #if __ARM_ARCH_ISA_THUMB == 1 To something like #if
> (__ARM_ARCH_6M__ == 1)
>
> Looks like in this case, there is no way to support Thumb for pre-armv6
> arches.

I'd be surprised if that was the case. The ARM ABI is older than
ARMv6M and ARMCC certainly supports those functions on ARM, Thumb 1
and 2.

I don't think we should have implementations for specific
architectures, only different ISAs. We already have too many of those.

cheers,
--renato