[PATCH] D28761: [ELF] Bypass section type check.

Evgeny Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 06:03:02 PST 2017


I didn't get your previous response, so I guess something went wrong with phab.

Regarding your question: I have kernel build script which generates 3 main sections (RX, RO, RW), 
grouping all sections with corresponding access permissions and assigns specific LMA to RX, RW and RO correspondingly. 
Both ld and gold process this script correctly out of the box.

My understanding is that even though init_array (and friends) has special type it's still an RW section,
so I think I should still be able to join it with other RW sections in linker script.

So is it okay to commit this patch as is?

________________________________________
От: Rafael Avila de Espindola <rafael.espindola at gmail.com>
Отправлено: 24 января 2017 г. 23:24
Кому: reviews+D28761+public+c00796a0207ed902 at reviews.llvm.org; Evgeny Leviant; ruiu at google.com
Копия: llvm-commits at lists.llvm.org; ikudrin.dev at gmail.com; George Rimar; adhemerval.zanella at linaro.org
Тема: Re: [PATCH] D28761: [ELF] Bypass section type check.

I replied befor, did Phab eat it?

  I would be OK with relaxing it. Please don't remove it completely just
  yet. We already have a case for allocating nobits sections.

  What exactly is the script trying to do? Why is .init_array being merged
  with .data?

Cheers,
Rafeal

Eugene Leviant via Phabricator <reviews at reviews.llvm.org> writes:

> evgeny777 added a comment.
>
> Rafael, can you please look at this? Thanks.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28761


More information about the llvm-commits mailing list