[PATCH] D29111: [SimplifyCFG] Do not sink and merge inline-asm instructions

[Akira Hatanaka via llvm-commits]

Thanks for the review, committed in r293025.

Can we merge this into 4.0?

On Tue, Jan 24, 2017 at 9:02 PM, David Majnemer via Phabricator <
reviews at reviews.llvm.org> wrote:

> majnemer accepted this revision.
> majnemer added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
>
> ================
> Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1440
> +
> +    // Conservatively return false if I is an inline-asm instruction.
> +    if (const auto *C = dyn_cast<CallInst>(I))
> ----------------
> I'd mention the constraint issue, it quickly explains why this is needed.
>
>
> https://reviews.llvm.org/D29111
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170124/3a1defd8/attachment.html>