[PATCH] D28696: DAG: Constant fold fp16_to_fp/fp16_to_fp

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 21:12:30 PST 2017


arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3335
       case ISD::FP_TO_SINT:
       case ISD::FP_TO_UINT:
       case ISD::TRUNCATE:
----------------
arsenm wrote:
> arsenm wrote:
> > RKSimon wrote:
> > > Add ISD::FP_TO_FP16: to vector constant folding?
> > I'm not sure these support vectors?
> The intrinsics do not, but I guess it could differ for the node
The intrinsics are turned into the normal FP casts instructions, so this only matters for targets using these for legalization purposes. It looks like only AMDGPU is doing this now, so I have no vector use/way to test it


https://reviews.llvm.org/D28696





More information about the llvm-commits mailing list