[PATCH] D28934: Write a new SSAUpdater

[Davide Italiano via llvm-commits]

On Tue, Jan 24, 2017 at 4:34 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
>
>
> On Tue, Jan 24, 2017 at 4:13 PM, Davide Italiano via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> davide added inline comments.
>>
>>
>> ================
>> Comment at: lib/Transforms/Utils/SSAUpdaterNew.cpp:197
>> +  SmallPtrSet<Value *, 8> InComponent;
>> +  DenseMap<Value *, unsigned int> Root;
>> +  SmallPtrSet<Value *, 8> PHISet;
>> ----------------
>> This seems to be more `PhiToDFSNum` than `Root`, unless I'm missing
>> something.
>>
> Short note:
> I copied the paper's name for it, so that the algorithm matches the paper,
> happy to change it.
>

Yeah, I noticed. But the NewGVN'ish name (PHIToDFSRoot) seems much
more self-explanatory to me =)