[PATCH] D28990: Align i128 to 16 bytes

[Simonas Kazlauskas via Phabricator via llvm-commits]

nagisa added a comment.

Its as @majnemer says, 16-byte alignment is required by ABI. Not just targets which use SysV, but any, where __int128 is supported, because clang hardcodes __int128 to have alignment of 16-bytes on *all* targets.

I’m surprised y'all are debating efficiency when its a plain correctness issue. IMHO what should be done is having the correctness issue fixed (this patch), then maybe some work towards removing the special case from clang (in the code I linked above) and finally incremental efficiency improvements where they are applicable.


https://reviews.llvm.org/D28990