[PATCH] D28836: [tsan] Provide API for libraries for race detection on custom objects

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 11:31:43 PST 2017


kubamracek added a comment.

> ...what happens when this new callbacks race with the old callback and/or tag is not assigned, or old callbacks + tag.

I'll address the comments, but just to follow up about the tags:  The patch adds tagging of heap memory (adds `tag` field into `MBlock`), basically only for the purpose of having a better "Location is..." line in the reports.  This "feature" is orthogonal to the rest of the patch and I can extract it into a separate patch if you want me to.

A second tagging happens, where we tag the memory accesses themselves (`external_tag` field in `ReportMop`).  This is used to identify that we're dealing with a race on a library object, rather than a regular race.


Repository:
  rL LLVM

https://reviews.llvm.org/D28836





More information about the llvm-commits mailing list