[PATCH] D29041: [tsan] Enable ignore_noninstrumented_modules=1 on Darwin by default

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: test/tsan/lit.cfg:30
+  # setting, but turn it back on for Darwin tests (see Darwin/lit.local.cfg).
+  default_tsan_opts += ':ignore_noninstrumented_modules=0'
 
----------------
dvyukov wrote:
> ignore_noninstrumented_modules=0 works because the generic tests use only libc and don't use any darwin-specific libraries, and tsan runtime handles most of the libc functions, right?
That's correct.  Libc doesn't really do any threading stuff unless you explicitly use pthread APIs.  Darwin-specific libraries do (XPC, dispatch, NSOperationQueue, ...).


Repository:
  rL LLVM

https://reviews.llvm.org/D29041