[PATCH] D29011: [IR] Add Freeze instruction

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added inline comments.


================
Comment at: lib/AsmParser/LLParser.cpp:5914
+  if (!Op->getType()->isIntegerTy())
+    return Error(Loc, "cannot freeze non-integer type");
+
----------------
filcab wrote:
> Please test this error.
Even better: Should this be in the verifier only? Otherwise you're checking for the same thing in two places, which is easy to get out of sync. (Would still require a test)


https://reviews.llvm.org/D29011