[PATCH] D29064: [MemorySSA] Add invariant.group handling

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added a comment.

In https://reviews.llvm.org/D29064#654390, @dberlin wrote:

> A few things
>
> 1. I'm curious why this isn't just added to the use optimizer more directly, it looks like you are computing info about most-dominating accesses, etc, which the stack already has.


do you mean optimizeUsesInBlock? I think this functions is already big enough with a lot of logic, so by having it in the different functions it is much simpler (and also the information about the stack is narrowed only to the things that I need)

> 2. If this isn't done in the walker, it'll never work in the face of updates. (IE the use optimizer is a faster version of the walker, it's not better. You are making something that is better, but if you don't add that to the walker, newly built memoryssa will support it but updated won't)

I haven't noticed that. I will fix the walker soon


https://reviews.llvm.org/D29064