[PATCH] D25428: AMDGPU add support for spilling to a user sgpr pointed buffers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM except for some pedantry



================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.cpp:300
 
-unsigned SISubtarget::getKernArgSegmentSize(unsigned ExplicitArgBytes) const {
-  unsigned ImplicitBytes = getImplicitArgNumBytes();
+unsigned SISubtarget::getKernArgSegmentSize(const MachineFunction &MF, unsigned ExplicitArgBytes) const {
+  unsigned ImplicitBytes = getImplicitArgNumBytes(MF);
----------------
Looks like it's over 80 columns


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:318
 
+  /* covers vs/ps/cs gfx shaders */
+  bool isMesaGfxShader(const MachineFunction &MF) const {
----------------
C++ style comment, capitalized


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:327
+
+
   /// \brief Returns the offset in bytes from the start of the input buffer
----------------
Extra line


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.cpp:1114-1117
+    } else {
+      assert(MFI->hasPrivateMemoryInputPtr());
+      return MFI->PrivateMemoryPtrUserSGPR;
+    }
----------------
No return after else


https://reviews.llvm.org/D25428