[PATCH] D29062: [InstCombine] Merge DebugLoc when speculatively hoisting store instruction

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 20:34:41 PST 2017


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Code LGTM, testcase could be improved a bit (comment inline).



================
Comment at: test/Transforms/SimplifyCFG/remove-debug-2.ll:3
+
+; CHECK: line: 1
+; CHECK: line: 2
----------------
These CHECKs could be improved by adding a little more context so it is more obvious what is being checked. This also makes it easier to update the test in the future.


https://reviews.llvm.org/D29062





More information about the llvm-commits mailing list