[llvm] r292826 - Attempt to fix the testcase in r292824

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 16:26:49 PST 2017


I can usually reproduce endian-ness bugs in the MachO YAML tools by adding:

IsLittleEndian:  false

Before the FileHeader is defined. That will generate a big-endian MachO, and most endian bugs go both ways.

I may have some time to look at this later this week.

-Chris

> On Jan 23, 2017, at 1:14 PM, Steven Wu via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> CC Chris B.
> 
> Apparently, this commit fixes the powerpc bots:
> http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3657 <http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3657>
> http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/3723 <http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/3723>
> 
> All I did is stripping out the segment load command and making the binary 64 bit x86_64. There might be some bug for ObjectYAML MachO format in these areas but I am unable to locate it just reading the code. Someone have access to IBM systems might be able to help?
> 
> Steven
> 
>> On Jan 23, 2017, at 12:42 PM, Steven Wu via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>> Author: steven_wu
>> Date: Mon Jan 23 14:42:17 2017
>> New Revision: 292826
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=292826&view=rev <http://llvm.org/viewvc/llvm-project?rev=292826&view=rev>
>> Log:
>> Attempt to fix the testcase in r292824
>> 
>> Try fix the testcase r292824 (failing on some bots) by reduce it to the
>> minimal. If this fix doesn't work, I will revert this test.
>> 
>> Modified:
>>    llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml
>> 
>> Modified: llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml?rev=292826&r1=292825&r2=292826&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml?rev=292826&r1=292825&r2=292826&view=diff>
>> ==============================================================================
>> --- llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml (original)
>> +++ llvm/trunk/test/ObjectYAML/MachO/build_version_command.yaml Mon Jan 23 14:42:17 2017
>> @@ -2,38 +2,15 @@
>> 
>> --- !mach-o
>> FileHeader:
>> -  magic:           0xFEEDFACE
>> -  cputype:         0x00000007
>> -  cpusubtype:      0x00000003
>> -  filetype:        0x00000004
>> -  ncmds:           2
>> -  sizeofcmds:      192
>> -  flags:           0x00000000
>> +  magic:           0xFEEDFACF
>> +  cputype:         0x01000007
>> +  cpusubtype:      0x80000003
>> +  filetype:        0x00000002
>> +  ncmds:           1
>> +  sizeofcmds:      32
>> +  flags:           0x00218085
>> +  reserved:        0x00000000
>> LoadCommands:
>> -  - cmd:             LC_SEGMENT_64
>> -    cmdsize:         152
>> -    segname:         __TEXT
>> -    vmaddr:          4294967296
>> -    vmsize:          8192
>> -    fileoff:         0
>> -    filesize:        3099
>> -    maxprot:         7
>> -    initprot:        5
>> -    nsects:          1
>> -    flags:           0
>> -    Sections:
>> -      - sectname:        __text
>> -        segname:         __TEXT
>> -        addr:            0x0000000100001160
>> -        size:            3099
>> -        offset:          0x00001160
>> -        align:           4
>> -        reloff:          0x00000000
>> -        nreloc:          0
>> -        flags:           0x80000400
>> -        reserved1:       0x00000000
>> -        reserved2:       0x00000000
>> -        reserved3:       0x00000000
>>   - cmd:             LC_BUILD_VERSION
>>     cmdsize:         32
>>     platform:        2
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170123/c64d62f9/attachment.html>


More information about the llvm-commits mailing list