[PATCH] D28600: [compiler-rt] [Sanitizer Coverage] Use interception to access to sanitizer coverage's strong functions defined in the main executable (for MD on Windows.)

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/asan/CMakeLists.txt:80
   ARCHS ${ASAN_SUPPORTED_ARCH}
-  SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES}
+  SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES} asan_win_weak_interception.cc
   CFLAGS ${ASAN_DYNAMIC_CFLAGS}
----------------
mpividori wrote:
> kubabrecka wrote:
> > Add asan_win_weak_interception.cc to ASAN_SOURCES instead.
> @kubamracek  I can't because this is only for the dynamic version of asan (dll).
Then either define something like ASAN_DYNAMIC_SOURCES or use `#if ASAN_DYNAMIC` in the source file itself.  This certainly doesn't belong here.


https://reviews.llvm.org/D28600