[PATCH] D28600: [compiler-rt] [Sanitizer Coverage] Use interception to access to sanitizer coverage's strong functions defined in the main executable (for MD on Windows.)

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/asan/CMakeLists.txt:80
   ARCHS ${ASAN_SUPPORTED_ARCH}
-  SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES}
+  SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES} asan_win_weak_interception.cc
   CFLAGS ${ASAN_DYNAMIC_CFLAGS}
----------------
kubabrecka wrote:
> Add asan_win_weak_interception.cc to ASAN_SOURCES instead.
@kubamracek  I can't because this is only for the dynamic version of asan (dll).


================
Comment at: lib/asan/asan_win_weak_interception.cc:14
+
+#ifdef _WIN32
+#include "asan_interface_internal.h"
----------------
kubabrecka wrote:
> Can you use the same ifdef'ing scheme as asan_win.cc is using, i.e.:
> 
>     #include "sanitizer_common/sanitizer_platform.h"
>     #if SANITIZER_WINDOWS
> 
> ?
@kubamracek Ok, you are right. Thanks.


https://reviews.llvm.org/D28600