[PATCH] D29021: [ELF] - Stop handling local symbols in a special way.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 11:00:25 PST 2017


ruiu added a comment.

Well, I think the problem was not in the code but in (the lack of) comments. It might have been OK if you add a comment saying that, for -r, we piggy back symbol's .symtab offsets to DynsymIndex because -r will never be used to produce DSOs. You probably want to spend more efforts on comments as it is sometimes the easiest way to solve a problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D29021





More information about the llvm-commits mailing list