[PATCH] D28942: [globalisel] Re-factor ISel matchers into a hierarchy. NFC

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 06:44:06 PST 2017


dsanders updated this revision to Diff 85377.
dsanders added a comment.
Herald added a subscriber: igorb.

- Moved predicate handling from OperandMatcher and InstructionMatcher to a common base class template WithPredicates. I don't seem to be able to factor out the emitCxxPredicateExpr() loop though. I should be able to use the same technique as for addPredicate() but it doesn't work. I'm looking into it.
- Add missing const's
- Fix comment typos
- Rename MatcherRule to RuleMatcher for consistency


https://reviews.llvm.org/D28942

Files:
  utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28942.85377.patch
Type: text/x-patch
Size: 11357 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170123/e022e582/attachment.bin>


More information about the llvm-commits mailing list