[PATCH] D28967: [PGO] Add option to view CFG with profile after profile annotation

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 21 18:52:43 PST 2017

davidxl added inline comments.

Comment at: Transforms/Instrumentation/PGOInstrumentation.cpp:151
+static cl::opt<std::string>
+    PGOViewCountsName("pgo-view-counts-name", cl::Hidden,
+                      cl::desc("The option to specify "
vsk wrote:
> Could you change the name of the flag to reference the fact that this enables filtering by function name? E.g 'pgo-inspect-func' or 'pgo-view-function'.

Comment at: Transforms/Instrumentation/PGOInstrumentation.cpp:1218
+#ifndef NDEBUG
+    if (PGOViewCounts &&
vsk wrote:
> Does this have to be guarded by NDEBUG? It seems strange that the cl::opt will be visible + non-functional in release mode.
this is currently true for BFI graph viewer. We may need to clean it up later (depending on the size impact to the release clang build).


More information about the llvm-commits mailing list