[PATCH] D28984: [LLD] Do not allocate space for common symbols with -r

Mark Kettenis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 21 15:59:33 PST 2017

kettenis added a comment.

h>>! In https://reviews.llvm.org/D28984#652498, @ruiu wrote:

> Can you add a test?


The alignment is returned as the VA because that's what's being stored in the st_value field of SHN_COMMON symbols.
Alternatively I could return 0 here, and fix up st_value in SymbolTableSection<ELFT>::writeGlobalSymbols(), but this way
seems a little bit cleaner.


More information about the llvm-commits mailing list