[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

bryant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 21 02:19:00 PST 2017


bryant added a comment.

In https://reviews.llvm.org/D28855#652366, @bryant wrote:

> - Further update `is_llvm_target` to `is_omitted_target_lib`. The former checks whether a component is part of a known target...


Just to clarify, this is incorrect because it checks for membership of any known target, **regardless of whether or not the target has been selected for building**.


Repository:
  rL LLVM

https://reviews.llvm.org/D28855





More information about the llvm-commits mailing list