[PATCH] D28075: MergeFunctions: Preserve debug info in thunks, under option -mergefunc-preserve-debug-info

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 14:50:52 PST 2017


aprantl added a comment.

In https://reviews.llvm.org/D28075#652048, @mehdi_amini wrote:

> In https://reviews.llvm.org/D28075#652044, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D28075#651966, @aprantl wrote:
> >
> > > @mehdi_amini, is this something you would like to see in this patch before it is committed, or in a follow-up patch?
> >
> >
> > The patch is good as is
>
>
> -> I didn't mean I reviewed it.


That's fine, I had already signed off the algorithm some time ago. Integrating it into clang / the LTO pipeline can be a separate commit IMHO.
@appcs this is good to go, but there should be a separate discussion/review for enabling the new pass.


https://reviews.llvm.org/D28075





More information about the llvm-commits mailing list