[PATCH] D28970: AMDGPU/SI: Give up in promote aloca when a pointer may be captured.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 13:59:16 PST 2017

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with the 2 additional tests

Comment at: test/CodeGen/AMDGPU/addrspacecast-captured.ll:14-15
+  %tmp = addrspacecast i32* %data to i32 addrspace(4)*
+  %0 = ptrtoint i32 addrspace(4)* %tmp to i32
+  store i32 %0, i32 addrspace(1)* %out
+  ret void
No unnamed values

Comment at: test/CodeGen/AMDGPU/addrspacecast-captured.ll:18
+attributes #0 = { nounwind }
Can you add another test which directly stores the addrspacecast, and another which passes the ptrtoint to an external call


More information about the llvm-commits mailing list