[PATCH] D28916: [ThinLTO] Fix lazy-loading of MDString instruction attachments

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 12:03:50 PST 2017

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

Thanks, I was able to build chrome successfully with CFI + debug info with this patch applied. LGTM (with nits) and approved for 4.0.

Comment at: llvm/lib/Bitcode/Reader/MetadataLoader.cpp:488
   bool hasFwdRefs() const { return MetadataList.hasFwdRefs(); }
   Metadata *getMetadataFwdRef(unsigned Idx) {
     return MetadataList.getMetadataFwdRef(Idx);
Is this function used any more?

Comment at: llvm/lib/Bitcode/Reader/MetadataLoader.cpp:1746
 /// necessary.
 Metadata *MetadataLoader::getMetadataFwdRef(unsigned Idx) {
+  return Pimpl->getMetadataFwdRefOrLoad(Idx);
Should this function be renamed to match?


More information about the llvm-commits mailing list