[PATCH] D28951: [ELF] - Linkerscripts: ignore CONSTRUCTORS in output section declaration.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 09:53:55 PST 2017

grimar added inline comments.

Comment at: ELF/LinkerScript.cpp:1453-1454
+    } else if (Tok == "CONSTRUCTORS") {
+      if (Config->Verbose)
+        elf::log(getCurrentLocation() + ": CONSTRUCTORS ignored for ELF");
     } else if (Tok == "FILL") {
ruiu wrote:
> We have a lot of things we silently ignore, and I don't find this is special, so no need to print out a message for that.
If honestly I would emit warning for this and other depricated things if any. I know we probably never will. Though I believe world requires some cleanup. I would be happy to cleanup my 25 years old scripts If I would have them :)
Otherwise one day somebody can end up with some NewSuperLLD and had to add tons of things it should ignore because some people did not restrict to have trash in scripts hundred years ago.


More information about the llvm-commits mailing list