[PATCH] D28898: [ELF] - Allow emulation to be different from input objects target.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 08:21:51 PST 2017

ruiu added a comment.

In https://reviews.llvm.org/D28898#651623, @grimar wrote:

> In https://reviews.llvm.org/D28898#651577, @ruiu wrote:
> > I don't think this patch works if all object files are in static archives.
> Original code also does not work when all files in static archives, no ? It requires -m or at least one .o file.

I think you actually changed the behavior. Now it needs at least one .o even if -m is given.

Comment at: ELF/Driver.cpp:700-701
 void LinkerDriver::inferMachineType() {
-  if (Config->EKind != ELFNoneKind)
-    return;
I think you could just remove this piece of code from inferMachineTypes to do the same thing, no?


More information about the llvm-commits mailing list