[PATCH] D28951: [ELF] - Linkerscripts: ignore CONSTRUCTORS in output section declaration.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 08:19:54 PST 2017

grimar added a comment.

In https://reviews.llvm.org/D28951#651624, @ruiu wrote:

> As I said, we need to write readable code so that even the first-time readers can understand it. If you were a stranger who happens to read this piece of code, you would wonder what this directive is and why it is ignored. Please write comments to describe why you are doing this. (I'm not saying that this needs a lengthy comment, but writing zero comments is not ok.)

Original patch did not require comments because had elf::log with clear message. I'll add comment and remove elf::log.


More information about the llvm-commits mailing list