[lld] r292359 - [ELF] Move createThunks() after scanRelocations()

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 02:11:11 PST 2017

Yes you are right, I missed that scanRelocs() would have already
stored the result of getThunkExpr() in Rel.Expr. Thanks for the

I've updated the patch and removed Type = Rel.Type and Body = *Rel.Sym
in favour of using them directly in the call to addThunk.

Let me know if that's ok to commit or if you want any more changes?


On 19 January 2017 at 20:37, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
> Peter Smith <peter.smith at linaro.org> writes:
>> +        RelExpr Expr = Rel.Expr;
>> +        Expr = Target->getThunkExpr(Expr, Type, IS->getFile(), Body);
> You can delete the call to getThunkExpr too, no?
> Cheers,
> Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ELF-Cleanup-createThunks-NFC.patch
Type: text/x-patch
Size: 2423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170120/f52c6f35/attachment.bin>

More information about the llvm-commits mailing list