[PATCH] D28911: [LinkerScript] WIP: Implement `MEMORY` command

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 01:40:06 PST 2017

grimar added inline comments.

Comment at: ELF/LinkerScript.cpp:1988
+    if (consume("(")) {
+      StringRef AttrStr = next();
+      expect(")");
grimar wrote:
> You do not use AttrStr, so you can just use 'next()'.
> May be worth to emit warning/error here about that attributes are not yet supported ?
Ah you're still working on attributes, please ignore this comment then.


More information about the llvm-commits mailing list