[PATCH] D28940: NewGVN: Fix PR 31686 by rewriting store leader handling.

Fri Jan 20 01:33:52 PST 2017

dberlin created this revision.

This rewrites store expression/leader handling.  We no longer use the
value operand as the leader, instead, we store it separately.  We also
now store the stored value as part of the expression, and compare it
when comparing stores for equality.  This enables us to get rid of a
bunch of our previous hacks and machinations, as the existing
machinery takes care of everything *except* updating the stored value
on classes.  The only time we have to update it is if the storecount
goes to 0, and when we do, we destroy it.

Since we no longer use the value operand as the leader, during elimination, we have to use the value operand.  Doing this also fixes a bunch of store forwarding cases we were missing.

Any value operand we use is guaranteed to either be updated by previous eliminations, or minimized by future ones.

(IE the fact that we don't use the most dominating value operand when it's not a constant does not affect anything).

Sadly, this change also exposes that we didn't pay attention to the
output of the pr31594.ll test, as it also very clearly exposes the
same store leader bug we are fixing here.

(I added pr31682.ll anyway, but maybe we think that's too large to be useful)

On the plus side, propagate-ir-flags.ll now passes due to the
corrected store forwarding.

This change was 3 stage'd on darwin and linux, with the full test-suite.

https://reviews.llvm.org/D28940

Files:
  include/llvm/Transforms/Scalar/GVNExpression.h
  lib/Transforms/Scalar/NewGVN.cpp
  test/Transforms/NewGVN/loadforward.ll
  test/Transforms/NewGVN/pr31594.ll
  test/Transforms/NewGVN/pr31686.ll
  test/Transforms/NewGVN/propagate-ir-flags.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28940.85104.patch
Type: text/x-patch
Size: 153374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170120/3ed60840/attachment-0001.bin>