[PATCH] D28898: [ELF] - Allow emulation to be different from input objects target.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 01:19:33 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D28898#650644, @ruiu wrote:

> If I understand correctly, you are trying to do this thing in this patch: set alternative values to page size, max page size and image base if -m is specified. Is this correct?


Main aim of that patch was to allow combination of -m elf_x86_64 and i386 objects.
Previously LLD took machine type and other data from -m and ignored inferring from objects and reported a error finally.
Patch changes logic to check objects first. And only after that check -m if not inferred data.

Setting alternative values is secondary thing here. Though it is looks consistent with what bfd do 
(https://llvm.org/bugs/show_bug.cgi?id=31678) and documentation in general I think.


https://reviews.llvm.org/D28898





More information about the llvm-commits mailing list