[PATCH] D28794: [NVPTX] Upgrade NVVM intrinsics in InstCombineCalls.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 17:43:37 PST 2017

jlebar marked 3 inline comments as done.
jlebar added inline comments.

Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1412
+    SimplifyAction() {}
majnemer wrote:
> jlebar wrote:
> > majnemer wrote:
> > > = default?
> > Is there a reason to prefer that over this syntax?  This is fewer chars, which is why I chose to do it this way.
> The constructor of SimplifyAction could be trivial because the compiler can see what's going on. This would not be so with a user defined constructor.
Thanks, done.


More information about the llvm-commits mailing list