[PATCH] D28927: [ValueTracking] Add comment that CannotBeOrderedLessThanZero does the wrong thing for powi.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 17:30:09 PST 2017

jlebar added a comment.

In https://reviews.llvm.org/D28927#651135, @efriedma wrote:

> we return the wrong result for a ton of stuff.

Yes.  :)  Again it's not clear to me what it's really supposed to do.

> I'd still prefer a bug report with a testcase over a TODO comment.

How about if you file a bug I'll edit the code to add a reference to it?  I'd like to have a breadcrumb in the code indicating that this is wrong so that the next person who comes along and notices the breakage doesn't waste days on it like I did.


More information about the llvm-commits mailing list