[PATCH] D28813: [CodeGenPrepare] Sink and duplicate more 'and' instructions.

Geoff Berry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 16:54:46 PST 2017

gberry marked an inline comment as done.
gberry added inline comments.

Comment at: lib/CodeGen/CodeGenPrepare.cpp:4699
       Builder.CreateAnd(Load, ConstantInt::get(Ctx, DemandBits)));
+  // Mark this instruction as "inserted by CGP", so that other
+  // optimizations don't touch it.
gberry wrote:
> mcrosier wrote:
> > I'm curious if this change in isolation prevented some other optimizations from happening?
> It shouldn't but I can verify that it doesn't.
Verified that this change (and above related one) make no difference to generated code across all of our tests.


More information about the llvm-commits mailing list