[PATCH] D28534: [LCSSA] Don't let SSAUpdater to break LCSSA during LCSSA construction.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 16:11:57 PST 2017

chandlerc added a comment.

Thanks for the ping!

Comment at: lib/Transforms/Utils/LCSSA.cpp:83-84
+  SmallVector<Instruction *, 4> Worklist;
+  Worklist.push_back(I);
The only hesitation I really have here is that this makes us do a lot more memory allocations when we're rewriting a lot of instructions with a lot of uses.

Is it worthwhile to try and share the worklists in some way? Have you looked at whether this worklist is just always small and so it doesn't matter in practice?


More information about the llvm-commits mailing list