[PATCH] D28914: [AliasAnalysis] Fences do not modify constant memory location
Daniel Berlin via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 14:20:38 PST 2017
Somewhere on my todo list is to cleanup getModRefInfo, and make
getModRefInfo the only interface memssa uses.
Right now, it has to differentiate between calls, fences, and other things
to call the right versions.
Interestingly, fences are the only memory modification instruction we have
that has no location, and if you call memorylocation::get on them, we crash.
On Thu, Jan 19, 2017 at 2:17 PM, Anna Thomas via Phabricator <
reviews at reviews.llvm.org> wrote:
> anna added a comment.
> Hi Daniel,
> In https://reviews.llvm.org/D28914#650775, @dberlin wrote:
> > Even though most AA related calls will crash trying to get a
> memorylocation from the fence, this looks right..
> I've seen the lack of memory locations in optimizations when using
> `memssa` version for optimizations. So, in such cases, it would still
> return `ModRef`.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits