[PATCH] D25295: [ubsan] Handle undef values in the integer overflow diagnostic

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 13:46:37 PST 2017

vsk updated this revision to Diff 85022.
vsk marked 4 inline comments as done.
vsk added a comment.

- Fix two overflow issues Filipe pointed out in inline comments.
- Remove the tests for undef values in diagnostic handlers. Instead, we are just testing the corner cases for the overflow checking logic. The rationale is that we don't want to mock up ubsan instrumentation in a test, and we also can't rely on the compiler treating UB in a consistent/testable way.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25295.85022.patch
Type: text/x-patch
Size: 6061 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/ab9cfce8/attachment-0001.bin>

More information about the llvm-commits mailing list