[PATCH] D28903: [ELF] - Do not crash when assign common symbol's values in script
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 12:55:27 PST 2017
George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> grimar added a comment.
> In https://reviews.llvm.org/D28903#650478, @meadori wrote:
>> IIUC, the crash is b/c `LinkerScript<ELFT>::getSymbolSection` has no code to handle the common symbol case. The fix is to use `SymbolTableSection<ELFT>::getOutputSection`, which does have code for handling commons (and various other kinds). If so, then LGTM.
> Yes, you're correct. Previously we just partially duplicated code from getSymbolSection().
> I probably had to write that in all description. Thank you for looking at this !
More information about the llvm-commits