[PATCH] D28068: Whenever reasonable, merge ASAN quarantine batches to save memory.

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 12:00:31 PST 2017

eugenis added a comment.


Comment at: lib/sanitizer_common/sanitizer_quarantine.h:38
+    batch[0] = ptr;
+    this->size = size + sizeof(QuarantineBatch);  // Account for the batch size.
+  }
alekseyshl wrote:
> eugenis wrote:
> > would it make the code simpler if we removed sizeof(QuarantineBatch) from here?
> I guess, you mean to do not account for the quarantine batch size here and calculate the overhead every time we check whether the quarantine limit is reached? It will simplify the code a little bit, but we will have to perform this calculation on every Put() call or, if we still going to roll it into size_, EnqueueBatch, DequeueBatch and MergeBatches will have to be aware of it (not that great too).
OK. Does not really matter.


More information about the llvm-commits mailing list