[PATCH] D28596: [compiler-rt] General definition for weak functions.
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 11:23:49 PST 2017
kubamracek added a comment.
> I don't want it to be possible for non-Windows developers to forget to use WIN_WEAK_FN. I would prefer it if the macro wrapped the function declaration so that it can't be forgotten. The Windows build is too often broken when adding weak functions.
Makes sense. Marcos, can we get an updated patch? I'll test it on Darwin.
More information about the llvm-commits