[PATCH] D28075: MergeFunctions: Preserve debug info in thunks, under option -mergefunc-preserve-debug-info

[David Blaikie via llvm-commits]

On Thu, Jan 19, 2017 at 11:12 AM Anmol P. Paralkar via Phabricator <
reviews at reviews.llvm.org> wrote:

> appcs added a comment.
>
> Thank you, everybody, for the valuable inputs.
>
> I understand the the codegen consistency [-g, -g0] requirement; I agree.
>
> Would it be fair to say that -mergefunc-preserve-debug-info is more suited
> to being placed under –Og?
>

There's still some hope that -Og may be only a compatibility flag & might
be able to be implemented as an alias for -O1.

That said, if this particular feature's a really good example of something
we really want to do for debugger use and that's the main/only reason to do
it - that'd be a really good discussion to have. If the community can come
to an agreement that that's true in this case we may be able to disprove
that -Og/-O1 equivalence goal sooner rather than later.

All I mean to say is it may require some discussion to work/walk through
all of this. (probably better had on llvm-dev or cfe-dev, rather than in a
review thread)


>
> I did not follow the "embed as a function attribute" part; please could
> you elaborate?
>
> I will submit a subsequent patch (upon this current base patch) that
> implements an API to enable/disable this behaviour
> (-mergefunc-preserve-debug-info) in the near future. Would that be alright?
>
> Is the current base patch (Diff 84419) OK to be committed?
>
>
> https://reviews.llvm.org/D28075
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/8387a1fc/attachment.html>