[PATCH] D28903: [ELF] - Do not crash when assign common symbol's values in script

Meador Inge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 08:29:16 PST 2017

meadori added a comment.

IIUC, the crash is b/c `LinkerScript<ELFT>::getSymbolSection` has no code to handle the common symbol case.  The fix is to use `SymbolTableSection<ELFT>::getOutputSection`, which does have code for handling commons (and various other kinds).  If so, then LGTM.


More information about the llvm-commits mailing list