[lld] r292359 - [ELF] Move createThunks() after scanRelocations()

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 07:06:14 PST 2017

No problem, is the attached patch ok?

> +          if (!isPreemptible(Body, Type) && needsPlt(Expr))
> +            Expr = fromPlt(Expr);
> +          Expr = Target->getThunkExpr(Expr, Type, IS->getFile(), Body);

I agree that these can be removed. Expr doesn't affect the decision in
getThunkExpr and as you point out we don't pass it on to a later

Thanks again for the suggestions


On 19 January 2017 at 14:08, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
> Peter Smith <peter.smith at linaro.org> writes:
>> Thanks for the comments,
>> I've got a follow up patch coming shortly to convert Thunks to using
>> synthetic sections, it involves touching this area and I can address
>> these then if its ok?
> It is probably better to have the code cleanup be an independent patch.
> Cheers,
> Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ELF-Cleanup-createThunks-NFC.patch
Type: text/x-patch
Size: 2600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/26a8def4/attachment.bin>

More information about the llvm-commits mailing list