[PATCH] D28609: [lsan] Enable LSan for x86 Linux.

[Maxim Ostapenko via Phabricator via llvm-commits]

m.ostapenko added inline comments.


================
Comment at: lib/lsan/lsan_common.h:29
+#elif SANITIZER_LINUX && !SANITIZER_ANDROID && defined(__i386__)
+#define CAN_SANITIZE_LEAKS 1
 #else
----------------
ygribov wrote:
> m.ostapenko wrote:
> > vitalybuka wrote:
> > > Can you explain in the comment why?
> > I'm sorry, I don't understand what exactly I should explain here? Why I enable LSan for x86 Linux only? FWIW, I wanted to combine the new condition with already existing one at lines 25-26, but found it to messy thus I decided to use separate #elif line.
> Probly add a comment that to enable other platforms one needs to implement clone?
Hm, ok. We also need (probably) update TLS machinery as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D28609